Document and test dontThrow for custom inline snapshot matchers#10995
Document and test dontThrow for custom inline snapshot matchers#10995SimenB merged 6 commits intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10995 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 309 309
Lines 13519 13519
Branches 3294 3294
=======================================
Hits 8683 8683
Misses 4122 4122
Partials 714 714 Continue to review full report at Codecov.
|
I didn't actually change any implementation. Or should I just add an entry like "Allow bailing out of failing tests with custom inline snapshot matchers"? |
|
Yeah, under |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #10888
Only documents it for inline snapshots since full snapshots would be reported as obsolete which isn't really ideal behavior. I guess ideally we could detect if obsolete snapshots are part of a test that failed and a note that they might not be obsolete after-all. For inline snapshots the current behavior with
dontThrowlooks ok to me.Test plan