Skip to content

chore: add invariant on ESM support in dynamic import#11164

Merged
SimenB merged 1 commit intojestjs:masterfrom
SimenB:dynamic-import-warning
Mar 6, 2021
Merged

chore: add invariant on ESM support in dynamic import#11164
SimenB merged 1 commit intojestjs:masterfrom
SimenB:dynamic-import-warning

Conversation

@SimenB
Copy link
Copy Markdown
Member

@SimenB SimenB commented Mar 6, 2021

Summary

Noticed in #11163 we got a really bad error in import usage:

image

Now it's

image

Which is not beautiful, but way more useful

Test plan

See screenshots 😀

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #11164 (c1f5b67) into master (26b2237) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11164      +/-   ##
==========================================
- Coverage   64.19%   64.18%   -0.01%     
==========================================
  Files         307      307              
  Lines       13372    13374       +2     
  Branches     3260     3260              
==========================================
  Hits         8584     8584              
- Misses       4083     4085       +2     
  Partials      705      705              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 55.41% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b2237...c1f5b67. Read the comment docs.

@SimenB SimenB merged commit 417650e into jestjs:master Mar 6, 2021
@SimenB SimenB deleted the dynamic-import-warning branch March 6, 2021 17:05
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants