fix(pretty-format): handles jsdom attributes properly#11189
Merged
SimenB merged 3 commits intojestjs:masterfrom Mar 14, 2021
Merged
fix(pretty-format): handles jsdom attributes properly#11189SimenB merged 3 commits intojestjs:masterfrom
SimenB merged 3 commits intojestjs:masterfrom
Conversation
|
Deploy preview for jestjs ready! Built without sensitive environment variables with commit d9eee82 |
SimenB
approved these changes
Mar 13, 2021
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 64.14% 64.14% -0.01%
==========================================
Files 307 307
Lines 13375 13379 +4
Branches 3260 3261 +1
==========================================
+ Hits 8580 8582 +2
- Misses 4089 4090 +1
- Partials 706 707 +1
Continue to review full report at Codecov.
|
jeysal
approved these changes
Mar 14, 2021
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #10770.
When received object mismatch with expected object, jest will copy received object with
deepCyclicCopyObject.As for this issue, received object contains jsdom provided objects
AbortController, and will encounterjsdom/lib/jsdom/living/attributes.This module also contains
hasAttribute,prettyFormat.plugins.DOMElement.testwill throw an exception by callinghasAttribute.Test plan
added
handles jsdom attributes properlytest.