docs: update timers config description#11376
Conversation
|
Hi @blimmer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
10429b6 to
91e5191
Compare
Codecov Report
@@ Coverage Diff @@
## master #11376 +/- ##
=======================================
Coverage 64.19% 64.19%
=======================================
Files 308 308
Lines 13519 13519
Branches 3293 3293
=======================================
Hits 8678 8678
Misses 4126 4126
Partials 715 715 Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
SimenB
left a comment
There was a problem hiding this comment.
thanks! just a couple of nits for the links 🙂
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
|
Updated! |
SimenB
left a comment
There was a problem hiding this comment.
thanks! from deploy preview the links work 🙂
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR clarifies the
timersconfiguration property based on the conversation in #11370.Fixes #11370
Test plan
Documentation change only.