Skip to content

Improve fatal worker error message #11381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
May 7, 2021
Merged

Improve fatal worker error message #11381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
587eb83
clarify error message
scitech May 6, 2021
5dca005
update test
scitech May 6, 2021
4fcc592
lint
scitech May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion e2e/__tests__/fatalWorkerError.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,7 @@ test('fails a test that terminates the worker with a fatal error', () => {
expect(exitCode).not.toBe(0);
expect(numberOfTestsPassed).toBe(Object.keys(testFiles).length - 1);
expect(stderr).toContain('FAIL __tests__/fatalWorkerError.test.js');
expect(stderr).toContain('Call retries were exceeded');
expect(stderr).toContain(
'Jest worker encountered 4 child process exceptions, exceeding retry limit',
);
});
4 changes: 3 additions & 1 deletion packages/jest-worker/src/workers/ChildProcessWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ export default class ChildProcessWorker implements WorkerInterface {
// coming from the child. This avoids code duplication related with cleaning
// the queue, and scheduling the next call.
if (this._retries > this._options.maxRetries) {
const error = new Error('Call retries were exceeded');
const error = new Error(
`Jest worker encountered ${this._retries} child process exceptions, exceeding retry limit`,
);

this._onMessage([
PARENT_MESSAGE_CLIENT_ERROR,
Expand Down
⚡