feat(jest-each): add support for interpolation with object properties#11388
Merged
SimenB merged 1 commit intojestjs:masterfrom May 8, 2021
Merged
Conversation
frozenbonito
force-pushed
the
add-support-interpolation-with-object-properties
branch
from
069b42a to
c6de1fc
Compare
frozenbonito
force-pushed
the
add-support-interpolation-with-object-properties
branch
from
c6de1fc to
5d1d65b
Compare
Codecov Report
@@ Coverage Diff @@
## master #11388 +/- ##
==========================================
- Coverage 64.20% 64.20% -0.01%
==========================================
Files 308 309 +1
Lines 13519 13524 +5
Branches 3293 3295 +2
==========================================
+ Hits 8680 8683 +3
- Misses 4125 4126 +1
- Partials 714 715 +1
Continue to review full report at Codecov.
|
SimenB
approved these changes
May 8, 2021
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
thanks! this is really good stuff 👍
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #10394
$variables are interpolated if the test name doesn't contain any of theprintfplaceholders (please refer to #10394 (comment) and #10394 (comment)).Test plan
Add unit tests.