fix: require.resolve on default test sequencer and test environment#11482
Merged
SimenB merged 3 commits intojestjs:masterfrom May 29, 2021
SamChou19815:require-resolve
Merged
fix: require.resolve on default test sequencer and test environment#11482SimenB merged 3 commits intojestjs:masterfrom SamChou19815:require-resolve
require.resolve on default test sequencer and test environment#11482SimenB merged 3 commits intojestjs:masterfrom
SamChou19815:require-resolve
Conversation
They are currently broken in yarn v2 pnp mode. See https://github.com/yarnpkg/berry/runs/2701218390
Codecov Report
@@ Coverage Diff @@
## master #11482 +/- ##
=======================================
Coverage 68.94% 68.95%
=======================================
Files 312 312
Lines 16309 16310 +1
Branches 4721 4722 +1
=======================================
+ Hits 11245 11246 +1
Misses 5036 5036
Partials 28 28
Continue to review full report at Codecov.
|
This was referenced May 30, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
They are currently broken in yarn v2 pnp mode. See https://github.com/yarnpkg/berry/runs/2701218390
For example, I have to add
@jest/test-sequencerandjest-environment-nodeas dependency to make the tests run in pnp mode. See SamChou19815/samlang#522Test plan
Added test cases on test environment default resolution.