Fix documentation of running ESM jest#11717
Merged
SimenB merged 4 commits intojestjs:mainfrom Sep 29, 2021
Merged
Conversation
`node_modules/.bin/jest` is a shell script; point instead to actual JavaScript which Node can run.
orta
approved these changes
Aug 10, 2021
Member
orta
left a comment
There was a problem hiding this comment.
Looks good, and we can ignore the reds - can you duplicate the change in https://github.com/facebook/jest/blob/master/docs/ECMAScriptModules.md so that it ends up in all future docs too please 👍🏻
Member
|
@edemaine could you update all editions of the versioned docs as well? |
Contributor
Author
|
Sorry for the delay. This should be fully propagated now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
node --experimental-vm-modules node_modules/.bin/jestdoesn't work (at least on Windows) becausenode_modules/.bin/jestis a shell script:node --experimental-vm-modules node_modules/jest/bin/jest.jsworks well for me by pointing directly to the JavaScript that Node can run. I saw this versionin this StackOverflow post.
Test plan