docs: Replace mkdirp with fsPromises.mkdir in Puppeteer.md#11951
Merged
SimenB merged 12 commits intojestjs:mainfrom Oct 13, 2021
munierujp:patch-1
Merged
docs: Replace mkdirp with fsPromises.mkdir in Puppeteer.md#11951SimenB merged 12 commits intojestjs:mainfrom munierujp:patch-1
SimenB merged 12 commits intojestjs:mainfrom
munierujp:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11951 +/- ##
=======================================
Coverage 68.76% 68.76%
=======================================
Files 322 322
Lines 16620 16620
Branches 4795 4795
=======================================
Hits 11429 11429
Misses 5159 5159
Partials 32 32 Continue to review full report at Codecov.
|
SimenB
requested changes
Oct 12, 2021
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
thanks! lefta. suggestion I think makes it even cleaner, but cleaning this up is nice 🙂
munierujp
changed the title
munierujp
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replce mkdirp with fsPromises.mkdir in Puppeteer.md
Test plan
This is a document-only change.
See also