chore(resolver): reuse cached lookup of package.json files#11969
Merged
SimenB merged 8 commits intojestjs:mainfrom Oct 17, 2021
Merged
chore(resolver): reuse cached lookup of package.json files#11969SimenB merged 8 commits intojestjs:mainfrom
SimenB merged 8 commits intojestjs:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11969 +/- ##
==========================================
- Coverage 68.76% 68.72% -0.05%
==========================================
Files 322 323 +1
Lines 16621 16631 +10
Branches 4797 4799 +2
==========================================
- Hits 11430 11429 -1
- Misses 5158 5169 +11
Partials 33 33
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supporting
exportsfield will lead us to reading way morepackage.jsonfiles than before, so in preparation we should try to make these caches cooperate and populate the same one.I've also dropped
escaladeas it does a bunch ofstatSynccalls - we do as well and cache them, so re-using makes sense.Lastly, I've moved the clearing of these caches until just before running tests (instead of only before runs in watch mode) in case some resolution is different between config loading and test running
Test plan
Green CI