fix: not to break on expect matcher extension overwrite#11978
Merged
SimenB merged 4 commits intojestjs:mainfrom Oct 19, 2021
Merged
fix: not to break on expect matcher extension overwrite#11978SimenB merged 4 commits intojestjs:mainfrom
expect matcher extension overwrite#11978SimenB merged 4 commits intojestjs:mainfrom
Conversation
blaky
changed the title
Contributor
|
Looks good. I am the one who broke this, so... thanks for fixing! @SimenB Would it make sense to add |
Member
|
Good call @mrazauskas, added that 🙂 |
SimenB
approved these changes
Oct 19, 2021
SimenB
changed the title
expect matcher extension overwrite
Contributor
Author
|
@SimenB thank you for the improvements and merging this PR. Do you have any ETA on when this could be released? |
Member
Contributor
Author
|
Thanks for the quick response 👍🏻 😆 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before #11949 it was possible to overwrite expect extensions. With this change I recover that functionality by adding
configurable: trueto theObject.definePropertycall which adds the extensions to the expect object.Please find more the details about the issue and a reproduction repo at #11977
Test plan
I added a unit test which ensure that this issue doesn't get reintroduced again to jest.