jest-environment-jsdom: Set @types/jsdom in dependencies

[Ayc0]

Summary

I'm using jest-environment-jsdom in one of my repository, but TypeScript is throwing this error when I'm using it:

.yarn/cache/jest-environment-jsdom-npm-27.3.1-2fb8134cca-669c4f417a.zip/node_modules/jest-environment-jsdom/build/index.d.ts:9:23 - error TS7016: Could not find a declaration file for module 'jsdom'. '.yarn/__virtual__/jsdom-virtual-d0a86cff2d/0/cache/jsdom-npm-16.6.0-f5f949a44e-4abf126bba.zip/node_modules/jsdom/lib/api.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/jsdom` if it exists or add a new declaration (.d.ts) file containing `declare module 'jsdom';`

import { JSDOM } from 'jsdom';

And it asks me to install @types/jsdom on my end.

But I think this is due to the fact that jsdom is imported and exposed in the declaration file (see exposed file):

In this case, I think that @types/jsdom should be set in the deps instead of devDeps, so that it'd be shipped to users of jest-environment-jsdom

Test plan

When setting those in my yarn berry config (which mimics the fact that @types/jsdom is marked as a dep and not a devDep), the error went away on my end:

[SimenB]

thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.