docs: changed 'before' and 'after' ---> 'beforeAll' and 'afterAll'#12065
Merged
SimenB merged 1 commit intojestjs:mainfrom Nov 29, 2021
Biki-das:01
Merged
docs: changed 'before' and 'after' ---> 'beforeAll' and 'afterAll'#12065SimenB merged 1 commit intojestjs:mainfrom Biki-das:01
SimenB merged 1 commit intojestjs:mainfrom
Biki-das:01
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12065 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 324 324
Lines 16669 16669
Branches 4814 4814
=======================================
Hits 11483 11483
Misses 5153 5153
Partials 33 33 Continue to review full report at Codecov.
|
Contributor
Author
|
@SimenB , found this one could you have a quick look on this! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple doc update to Setup and Teardown
While reading, I was confused by references to before and after, which have been removed. It seems like these should be beforeAll and afterAll instead of before and after. Alternatively, we could use before* like in the Order of execution step, but it seems like beforeAll/afterAll are the better fit here.