Skip to content

docs: changed 'before' and 'after' ---> 'beforeAll' and 'afterAll'#12065

Merged
SimenB merged 1 commit intojestjs:mainfrom
Biki-das:01
Nov 29, 2021
Merged

docs: changed 'before' and 'after' ---> 'beforeAll' and 'afterAll'#12065
SimenB merged 1 commit intojestjs:mainfrom
Biki-das:01

Conversation

@Biki-das
Copy link
Copy Markdown
Contributor

Simple doc update to Setup and Teardown

While reading, I was confused by references to before and after, which have been removed. It seems like these should be beforeAll and afterAll instead of before and after. Alternatively, we could use before* like in the Order of execution step, but it seems like beforeAll/afterAll are the better fit here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #12065 (fd627db) into main (42b020f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12065   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files         324      324           
  Lines       16669    16669           
  Branches     4814     4814           
=======================================
  Hits        11483    11483           
  Misses       5153     5153           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b020f...fd627db. Read the comment docs.

@Biki-das
Copy link
Copy Markdown
Contributor Author

@SimenB , found this one could you have a quick look on this!

Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@SimenB SimenB merged commit ef25c46 into jestjs:main Nov 29, 2021
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants