Enhancing the toHaveProperty matcher to support array selection#12092
Merged
SimenB merged 8 commits intojestjs:mainfrom Nov 29, 2021
Merged
Enhancing the toHaveProperty matcher to support array selection#12092SimenB merged 8 commits intojestjs:mainfrom
toHaveProperty matcher to support array selection#12092SimenB merged 8 commits intojestjs:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12092 +/- ##
==========================================
+ Coverage 68.89% 68.90% +0.01%
==========================================
Files 324 324
Lines 16668 16677 +9
Branches 4813 4814 +1
==========================================
+ Hits 11483 11492 +9
Misses 5152 5152
Partials 33 33
Continue to review full report at Codecov.
|
iifawzi
commented
Nov 27, 2021
e3515c3 to
794c62d
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi, this PR is adding the feature requested at #7284 as mentioned #7284 (comment) to support array selection while using the
toHavePropertymatcher.Test plan
All previous matchers tests are working as expected, and I've also added more test cases to test the functionality, let me know if I need to add more tests.