chore: update to TypeScript 4.8

[SimenB]

Summary

https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/

Test plan

Green CI

[SimenB]

Aww.

@mrazauskas thoughts? we might need to patch ansi-escapes as it's ESM only in the latest versions

[mrazauskas]

Sure. I will take a look bit later.

If ansi-escapes is the trouble, it is easy replaceable by adding a couple of tiny functions in jest-util. Some Ansi sequences already live there, e.g: https://github.com/facebook/jest/blob/630d099e2e7deeb38eac1aaccf37f7f9f9d77335/packages/jest-util/src/specialChars.ts#L18

Or with Node’s built-ins like WriteStream.prototype.cursorTo(), but somehow own functions sounds better.

[SimenB]

It's not ansi-escapes actually, it's type-fest (I just read the error too quickly 😅): node_modules/ansi-escapes/node_modules/type-fest/ts41/get.d.ts

[mrazauskas]

I just did the same and it works ;D

There is also jasmine related error. I think it can be ignored with @ts-expect-error.

[nfroidure]

Since I updated to the last TypeScript version 4.8.2, I get the following type error :

node_modules/@jest/environment/build/index.d.ts:329:26 - error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.
  The types returned by 'jest.createMockFromModule(...)' are incompatible between these types.
    Type 'unknown' is not assignable to type 'T'.
      'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

329 export declare interface JestImportMeta extends ImportMeta {
                             ~~~~~~~~~~~~~~


Found 1 error in node_modules/@jest/environment/build/index.d.ts:329

Do you think this commit will fix it on with the next version?

To test by yourself, just clone this module and npm i && npm run build :
https://github.com/nfroidure/common-services

[mrazauskas]

@nfroidure I just followed the reproduction steps you provided. The library got build without any error.

The strange things: I see is that package-lock.json got modified; and I see "typescript": "^4.7.3" in your package.json. Not the version you are complaining about.

Changing the version to "^4.8.2" and running the commands again gives 117 TypeScript errors ("Found 117 errors in the same file, starting at: node_modules/knifecycle/dist/util.d.ts:100"). I can’t see nothing Jest related at the moment.

Might be something went wrong with reproduction. Just leaving a comment. Would be better to open a new issue with minimal reproduction.

[nfroidure]

The ^ make the latest version to be installed with npm (ie 4.8.2), you should see the Jest one in the several errors, the others are ones I fixed by my side. I'll try to reproduce it in a smaller repo.

[nfroidure]

Ok, I found the problem, it comes from @types/jest:

mkdir test && cd test
npm init -y
npm i -D typescript jest
npm i -d @types/jest
echo "import { jest } from '@jest/globals';" > test.ts
npm exec --package=typescript -- tsc test.ts

Gives:

node_modules/@jest/environment/build/index.d.ts:329:26 - error TS2430: Interface 'JestImportMeta' incorrectly extends interface 'ImportMeta'.
  The types returned by 'jest.createMockFromModule(...)' are incompatible between these types.
    Type 'unknown' is not assignable to type 'T'.
      'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

329 export declare interface JestImportMeta extends ImportMeta {
                             ~~~~~~~~~~~~~~


Found 1 error in node_modules/@jest/environment/build/index.d.ts:329

I'll report it to the concerned repo, thanks for your answer.

[mrazauskas]

If you import { jest } from '@jest/globals', types of jest object will be pulled jest and the rest of global APIs will get typed through @types/jest.

I would recommend importing all APIs (describe, test, etc.) from @jest/globals. That way you will not need @types/jest and Jest’s types will be always up to date.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.