Skip to content

Add caution note to '.' usage in moduleDirectories#14913

Merged
SimenB merged 3 commits intojestjs:mainfrom
davidroeca:resolve-10498
May 29, 2024
Merged

Add caution note to '.' usage in moduleDirectories#14913
SimenB merged 3 commits intojestjs:mainfrom
davidroeca:resolve-10498

Conversation

@davidroeca
Copy link
Copy Markdown
Contributor

Resolves #10498

Summary

Adds a simple warning message to the docs, discouraging the use of '.' as part of moduleDirectories.

Test plan

N/A - just a docs update

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Feb 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 21, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit acdc407
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66573b4fe712110008bb14bd
😎 Deploy Preview https://deploy-preview-14913--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks! could you add the same note to all the versions of this doc?

image

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Mar 17, 2024

Oh, and sign the CLA 🙂

@SimenB
Copy link
Copy Markdown
Member

SimenB commented May 29, 2024

@davidroeca ping 🙂

@davidroeca
Copy link
Copy Markdown
Contributor Author

@SimenB done!

Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 4280a31 into jestjs:main May 29, 2024
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature/Bug Report] Discourage/disable "./" as one of the "moduleDirectories"

2 participants