Skip to content

Show exception stack trace when errors are thrown by plugins of pretty-format #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasiensen wants to merge 5 commits into from
Closed

Show exception stack trace when errors are thrown by plugins of pretty-format #4738

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3537657
Catch errors thrown by custom snapshot serializers
nicolasiensen Oct 21, 2017
caf9e31
Merge branch 'master' of github.com:nicolasiensen/jest into catch-sna…
nicolasiensen Oct 21, 2017
04d450b
Remove error handling added previously in toMatchSnapshot func (undo)
nicolasiensen Oct 22, 2017
e572c7c
Catch and throw the error stack of plugins in pretty-format
nicolasiensen Oct 22, 2017
77bcbb7
Add entry to the CHANGELOG for the fix introduced in this pull request
nicolasiensen Oct 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/jest-snapshot/src/__tests__/matcher.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,17 @@ it(`matcher returns matcher name, expected and actual values`, () => {
}),
);
});

it(`throws the error stack when match throws an error`, () => {
const error = new Error();

const matcher = toMatchSnapshot.bind({
snapshotState: {
match: () => {
throw error;
},
},
});

expect(() => matcher()).toThrow(error.stack);
});
19 changes: 13 additions & 6 deletions packages/jest-snapshot/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,19 @@ const toMatchSnapshot = function(received: any, testName?: string) {
throw new Error('Jest: snapshot state must be initialized.');
}

const result = snapshotState.match(
testName && currentTestName
? `${currentTestName}: ${testName}`
: currentTestName || '',
received,
);
let result;

try {
result = snapshotState.match(
testName && currentTestName
? `${currentTestName}: ${testName}`
: currentTestName || '',
received,
);
} catch (error) {
throw new Error(error.stack);
}

const {count, pass} = result;
let {actual, expected} = result;

Expand Down
⚡