-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Don't report errors errors as unhandled if there is an existing "error" event handler #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b41c5fb
Add failing integration test for rethrowing after nested event loop
gaearon c34bf7a
Remove log
gaearon 342312f
Remove jest's error listener if usercode adds its own
SimenB 85dc69b
Fix lint
gaearon ebf28dd
Fix lint error in tests
SimenB edccd39
Keep track of listeners
gaearon 6f01ccd
No ...args
gaearon 35b0746
The slings and arrows of outrageous fortune
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @flow | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| const runJest = require('../runJest'); | ||
|
|
||
| test('works with nested event loops', () => { | ||
| const result = runJest('nested_event_loop'); | ||
| expect(result.status).toBe(0); | ||
| }); |
31 changes: 31 additions & 0 deletions
31
integration_tests/nested_event_loop/__tests__/nested_event_loop.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /** | ||
| * Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @jest-environment jsdom | ||
| */ | ||
|
|
||
| /* eslint-env browser */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| it('can assert on errors across nested event loops', () => { | ||
| const el = document.createElement('div'); | ||
| el.addEventListener('fake', () => { | ||
| throw new Error('This should be caught.'); | ||
| }); | ||
| let caught = null; | ||
| window.addEventListener('error', e => { | ||
| caught = e.error; | ||
| }); | ||
| expect(() => { | ||
| const evt = document.createEvent('Event'); | ||
| evt.initEvent('fake', false, false); | ||
| el.dispatchEvent(evt); | ||
| if (caught) { | ||
| throw caught; | ||
| } | ||
| }).toThrow(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "jest": { | ||
| "testEnvironment": "jsdom" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of manual bookkeeping, can we just check the total number of listeners here?
e.g. this works in chrome:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
getEventListenersis not available for jsdom@9 at leastEDIT: Or in 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with upgrading to 11 and dropping node 4 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a devtools API, so never mind!
https://developers.google.com/web/tools/chrome-devtools/console/command-line-reference#geteventlistenersobject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4769