test: handle both ms and s in test timings#5132
Conversation
| const rest = cleanupStackTrace( | ||
| // remove all timestamps | ||
| stdout.slice(0, -match[0].length).replace(/\s*\(.*ms\)/gm, ''), | ||
| stdout.slice(0, -match[0].length).replace(/\s*\(\d*\.?\d+m?s\)/gm, ''), |
There was a problem hiding this comment.
just adding m?s made a single other test fail, so this is copied from the cleanup regexp above
There was a problem hiding this comment.
Maybe worth to add a $ so we match only the end of the string?
There was a problem hiding this comment.
Yeah, that probably would have fixed it. added it anyways 🙂
Codecov Report
@@ Coverage Diff @@
## master #5132 +/- ##
======================================
Coverage 60.7% 60.7%
======================================
Files 201 201
Lines 6691 6691
Branches 4 4
======================================
Hits 4062 4062
Misses 2628 2628
Partials 1 1Continue to review full report at Codecov.
|
|
Damn, CI is slow. |
|
runInBand takes quite some time... the whole (integration) test run is 70s on my machine |
|
We should be able to run on at least 2 or 4 cores with |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
Summary
We're seeing some errors from slow running tests in seconds instead of millis. This strips them out from test results in integration tests.
Test plan
Green CI