Fix updateSnapshot resetting after updating snapshots in watch mode#5256
Fix updateSnapshot resetting after updating snapshots in watch mode#5256cpojer merged 1 commit intojestjs:masterfrom
Conversation
b4564d6 to
ed8615f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5256 +/- ##
==========================================
+ Coverage 61.14% 61.14% +<.01%
==========================================
Files 203 203
Lines 6843 6844 +1
Branches 3 4 +1
==========================================
+ Hits 4184 4185 +1
Misses 2658 2658
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@chrisbujok I agree it would be great to just set it to new, but I wonder if there are cases where it should have been reseted to all, so probably reseting to the previous one makes more sense... I think @aaronabramov might know better
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #4869
I'm not sure if current behavior was intended, but this fix works for me.
Also I wonder if it'd be enough to always reset to
newinstead ofnone, since it runs in the watch mode?