Document caveat with mocks, Enzyme, snapshots and React 16#5275
Merged
thymikee merged 3 commits intojestjs:masterfrom Jan 11, 2018
Merged
Document caveat with mocks, Enzyme, snapshots and React 16#5275thymikee merged 3 commits intojestjs:masterfrom
thymikee merged 3 commits intojestjs:masterfrom
Conversation
Closes jestjs#5258. Update the documentation to describe the warnings that are emitted by React 16 when using Enzyme, mocked components and snapshot testing.
Contributor
|
Maybe it's still worth documenting the custom element workaround? |
Contributor
Author
|
I've updated the docs with the options that @gaearon outlined. |
SimenB
approved these changes
Jan 11, 2018
Contributor
|
Thank you @pugnascotia and @gaearon for making the docs better! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5258.
Summary
Update the documentation to describe the warnings that are emitted by React 16 when using Enzyme, mocked components and snapshot testing.
Also fix the website instructions in the contribution guidelines.
Test plan