Update Configuration.md#5287
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5287 +/- ##
=======================================
Coverage 60.98% 60.98%
=======================================
Files 203 203
Lines 6816 6816
Branches 4 3 -1
=======================================
Hits 4157 4157
Misses 2658 2658
Partials 1 1Continue to review full report at Codecov.
|
|
Thank you! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR adds note to
globalssetting that its contents need to be json serializable, and thus its not supporting functions for its values. This is something that originally has bitten me once I've moved to parallelized tests execution and it feels to me that this should be documented somewhere.Test plan
This is documentation's change.