Add link to the list of methods to go to spyOn accessType for Jest Object API doc#5404
Merged
SimenB merged 1 commit intojestjs:masterfrom Jan 27, 2018
ahnpnl:fix/add-title-spyOn-accessType-forAPIDoc
Merged
Add link to the list of methods to go to spyOn accessType for Jest Object API doc#5404SimenB merged 1 commit intojestjs:masterfrom ahnpnl:fix/add-title-spyOn-accessType-forAPIDoc
SimenB merged 1 commit intojestjs:masterfrom
ahnpnl:fix/add-title-spyOn-accessType-forAPIDoc
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5404 +/- ##
=======================================
Coverage 61.32% 61.32%
=======================================
Files 205 205
Lines 6925 6925
Branches 4 3 -1
=======================================
Hits 4247 4247
Misses 2677 2677
Partials 1 1Continue to review full report at Codecov.
|
SimenB
approved these changes
Jan 27, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the API Doc doesn't have the link to go to jest.spyOn(object, methodName, accessType?). This PR makes the developers easy to navigate to jest.spyOn(object, methodName, accessType?) method description by clicking the link on the list of methods on the top of the API doc page.
Test plan
yarn startin the website directory.http://localhost:3000/jest/docs/en/jest-object.htmlusing any browsersjest.spyOn(object, methodName, accessType?)jest.spyOn(object, methodName, accessType?)and see if it navigates correctly to the usage description of the method