Conversation
jeanlauliac
force-pushed
the
add-platform-specific-deletion-test
branch
from
490f34c to
b57160c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5508 +/- ##
=======================================
Coverage 61.69% 61.69%
=======================================
Files 213 213
Lines 7077 7077
Branches 3 4 +1
=======================================
Hits 4366 4366
Misses 2710 2710
Partials 1 1Continue to review full report at Codecov.
|
Member
|
Nice! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have two files
A.jsandA.ios.js, removing the second one will not properly updatejest-haste-mapcache. This causesjestor dependents to crash, as they try to access a now non-existent path. This changeset adds a test that reproduce the issue, along with complementary tests to verify other variations on the theme are not broken. These tests try to ensure that the follow-up fix will not break the platform-specific files handling in other ways.