Skip to content

stop wrapping markdown#6299

Merged
thymikee merged 1 commit intojestjs:masterfrom
SimenB:never-wrap-md
May 27, 2018
Merged

stop wrapping markdown#6299
thymikee merged 1 commit intojestjs:masterfrom
SimenB:never-wrap-md

Conversation

@SimenB
Copy link
Copy Markdown
Member

@SimenB SimenB commented May 26, 2018

Summary

We have stupid linting errors on the markdown all the time. My hypothesis is that we'll get way less of them if we can at least eliminate the ones with errors around line length in prose.

Test plan

N/A

Comment thread package.json
"prettier": {
"bracketSpacing": false,
"proseWrap": "always",
"proseWrap": "never",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MVP

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6299   +/-   ##
=======================================
  Coverage   63.54%   63.54%           
=======================================
  Files         221      221           
  Lines        8502     8502           
  Branches        3        4    +1     
=======================================
  Hits         5403     5403           
  Misses       3098     3098           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d127ff...a569cc1. Read the comment docs.

@thymikee thymikee merged commit 6eeadab into jestjs:master May 27, 2018
@SimenB SimenB deleted the never-wrap-md branch May 27, 2018 00:16
@SimenB
Copy link
Copy Markdown
Member Author

SimenB commented May 27, 2018

this'll look awesome on the contribution graph

@thymikee
Copy link
Copy Markdown
Contributor

Blazing good

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants