jest-circus: feature parity#6328
Conversation
|
Or until we kill |
Codecov Report
@@ Coverage Diff @@
## master #6328 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 228 228
Lines 8705 8705
Branches 3 3
=======================================
Hits 5562 5562
Misses 3142 3142
Partials 1 1Continue to review full report at Codecov.
|
| return process.env.JEST_CIRCUS === '1'; | ||
| }, | ||
|
|
||
| skipSuiteOnJasmine() { |
There was a problem hiding this comment.
we'll probably need this when we start adding tests for things that we fixed in circus but that don't work in jasmine (like nested test or running hooks when there's no tests)
There was a problem hiding this comment.
ok, brought it back
|
Amazing work, guys. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
jest-circusis now fully compatible with Jasmine.cc @captbaritone
Fixes #4362
Test plan
Ideas how to make
https://github.com/facebook/jest/blob/a43fd6c75d2f38616407a70c69ccaee666cb4f61/scripts/ConditionalTest.js#L13-L15
more env independent?
This is the only place we use it:
https://github.com/facebook/jest/blob/9310e9ce497cd2e186c00e70dbc5165706ba5a0d/e2e/__tests__/location_in_results.test.js#L39
Or should we create 2 tests, one for circus, second fo jasmine?