globalSetup and globalTeardown use default export with es modules#7750
Merged
SimenB merged 3 commits intojestjs:masterfrom Jan 29, 2019
Merged
globalSetup and globalTeardown use default export with es modules#7750SimenB merged 3 commits intojestjs:masterfrom
SimenB merged 3 commits intojestjs:masterfrom
Conversation
SimenB
reviewed
Jan 29, 2019
SimenB
approved these changes
Jan 29, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Thanks, great idea! Just left a nit 🙂
chrisblossom
commented
Jan 29, 2019
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#7562 allowed for transpiling
global{Setup,Teardown}which requires a function be exported. This change allows for exporting a default function with es modules.Test plan
Added e2e tests.