Watch mode number of CPUs & documentation.#8211
Watch mode number of CPUs & documentation.#8211scotthovestadt merged 2 commits intojestjs:masterfrom
Conversation
cpojer
left a comment
There was a problem hiding this comment.
Nice, thank you for changing this back and adding docs for it.
|
|
||
| return parsed > 0 ? parsed : 1; | ||
| } else { | ||
| // In watch mode, Jest should be unobtrusive and not take all available CPU. |
There was a problem hiding this comment.
"[…] not use all available CPUs."?
Codecov Report
@@ Coverage Diff @@
## master #8211 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 265 265
Lines 10534 10534
Branches 2555 2556 +1
=======================================
Hits 6564 6564
Misses 3387 3387
Partials 583 583
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Revert change to number of CPUs and add docs to resolve @cpojer comment:
#8201 (comment)
Benchmarked Jest non-e2e test performance for this branch from 14.973s to 16.504s, which is still a massive win over the original 23.234s and probably points to further optimizations being possible since I'd hope that giving it 5 extra CPUs would do more for the performance.
Test plan