fix: Allow setting extra options in this.global for Typescript#8758
Merged
SimenB merged 1 commit intojestjs:masterfrom Jul 28, 2019
Merged
fix: Allow setting extra options in this.global for Typescript#8758SimenB merged 1 commit intojestjs:masterfrom
SimenB merged 1 commit intojestjs:masterfrom
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per the documentation of testEnvironment
However if I'm writing my environment in Typescript, assigning a variable in
this.globalis reported as an error by the compiler, due to the strict typing ofGlobalBased on a discussion from #8751
Test plan
Existing e2e tests should cover it.