Refractor requireAndTranspileModule to use exts from moduleFileExtenstions#8895
Merged
SimenB merged 1 commit intojestjs:masterfrom Aug 30, 2019
Merged
Refractor requireAndTranspileModule to use exts from moduleFileExtenstions#8895SimenB merged 1 commit intojestjs:masterfrom
SimenB merged 1 commit intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8895 +/- ##
==========================================
- Coverage 64.21% 64.21% -0.01%
==========================================
Files 275 275
Lines 11657 11658 +1
Branches 2847 2847
==========================================
Hits 7486 7486
- Misses 3545 3546 +1
Partials 626 626
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the current implementation of
requireAndTranspileModuletheextensionsused for pirates is determined bypath.extname.path.extnamereturns empty string for directories, which resulted inPnPtest failing in #8854. Restricting the extensions to the ones specified inmoduleFileExtensions/cc @SimenB @jeysal
Test plan
Existing tests should not break
All PRs related to #8810 should not be affected