chore: get rid of custom abstraction on top of execa in e2e tests#8901
Merged
SimenB merged 3 commits intojestjs:masterfrom Sep 2, 2019
Merged
chore: get rid of custom abstraction on top of execa in e2e tests#8901SimenB merged 3 commits intojestjs:masterfrom
SimenB merged 3 commits intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8901 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 275 275
Lines 11656 11656
Branches 2844 2843 -1
=======================================
Hits 7488 7488
Misses 3544 3544
Partials 624 624Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the mapping of
exitCode -> status. Also types thejsonfield properlyTest plan
Green CI