jest-diff: Do not inverse format if line consists of one change#8903
Merged
SimenB merged 2 commits intojestjs:masterfrom Sep 4, 2019
Merged
jest-diff: Do not inverse format if line consists of one change#8903SimenB merged 2 commits intojestjs:masterfrom
SimenB merged 2 commits intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8903 +/- ##
==========================================
+ Coverage 64.24% 64.24% +<.01%
==========================================
Files 275 275
Lines 11656 11658 +2
Branches 2844 2846 +2
==========================================
+ Hits 7488 7490 +2
Misses 3544 3544
Partials 624 624
Continue to review full report at Codecov.
|
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 18, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 17, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It distracts attention of reviewer if entire change line has inverse format
Test plan
Updated snapshots:
Realistic regression tests for the win: the code change was more subtle than I thought
Example pictures baseline at left and improved at right
The inverse lines fight for attention with the substrings within lines:
The inverse lines add insult to injury
when cleanup merges:fromandtointo changes because commonois chaffTo set the record straight, merging
ochaff intofromandtochanges is good cleanup. The problem is the length criterion where common substring'change '.lengthdoes not have greater length than adjacent change substring'delete\n'.lengthso is merged into changes.Notice the effect of one character increase in length to
'changed '