Fix --testNamePattern matching against it.concurrent within describe#9090
Fix --testNamePattern matching against it.concurrent within describe#9090SimenB merged 3 commits intojestjs:masterfrom dmitri-gb:fix-concurrent-spec-filtering
Conversation
|
Hi dmitri-gb! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9090 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 277 277
Lines 11702 11702
Branches 2872 2871 -1
=======================================
Hits 7573 7573
Misses 3514 3514
Partials 615 615
Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR aims to fix an issue with
it.concurrentwhere a test is marked as PASSED without even being invoked when--testNamePatternis used to select the test. This has been reported e.g. in #5071. The issue also manifests every time a single test (defined withit.concurrent) is run in the WebStorm IDE using the "run" gutter icon.Fixes #5071
Test plan
I included an integration test that demonstrates the issue.