feat: pass ESM options to transformers by SimenB · Pull Request #9597 · jestjs/jest

SimenB · 2020-02-19T11:56:13Z

Summary

When jest-runtime supports ESM, then babel can leave those statements alone. While not usable yet, this helps reduce the eventual diff for ESM.

Test plan

~~Added some unit tests to some funky merging code, otherwise~~ this is not really testable until we land more ESM stuff. While it's all added as optional to avoid a breaking change, jest-runtime explicitly opts out if it, so no real way of triggering this.

codecov-io · 2020-02-19T12:49:42Z

Codecov Report

Merging #9597 into master will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #9597      +/-   ##
==========================================
+ Coverage   65.09%   65.11%   +0.01%     
==========================================
  Files         287      287              
  Lines       12145    12151       +6     
  Branches     3009     3015       +6     
==========================================
+ Hits         7906     7912       +6     
  Misses       3604     3604              
  Partials      635      635

Impacted Files	Coverage Δ
packages/jest-runtime/src/index.ts	`65.75% <ø> (ø)`	⬆️
packages/jest-transform/src/ScriptTransformer.ts	`70.17% <66.66%> (+0.53%)`	⬆️
packages/babel-jest/src/index.ts	`52.94% <80%> (+2.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a879d...a7fac13. Read the comment docs.

SimenB · 2020-02-19T12:58:08Z

    fileData: string,
    filename: Config.Path,
    instrument: boolean,
+    supportsDynamicImport: boolean,


I made them non-optional for all private methods and default false for the public ones

should ideally use options objects, as 2-3 boolean flag inputs are quite confusing

Generally agree, but IIRC functions with more arguments are optimized better than the ones with object arguments, and this is kinda hot path

potentially we could add separate functions? the es module path can be async (or rather, always is) as well, so that might tie nicely into #9504. Then we could ditch the supportsDynamicImport option since that works for both esm and cjs (and can be async) and just vary on the static version

thymikee

Would reduce tests duplication with test.each, but other than that looks fine

thymikee · 2020-02-19T20:01:05Z

    fileData: string,
    filename: Config.Path,
    instrument: boolean,
+    supportsDynamicImport: boolean,


Generally agree, but IIRC functions with more arguments are optimized better than the ones with object arguments, and this is kinda hot path

SimenB · 2020-04-05T09:08:32Z

Extracted the babel-jest stuff to #9766, makes this PR a bit cleaner, and I don't dislike the approach as much anymore

SimenB · 2020-04-05T09:09:02Z

    return {
      ...options,
      ...this._coverageOptions,
+      supportsDynamicImport: false,


should have been in #9766, meh

SimenB · 2020-04-05T09:09:37Z


  private _transformAndBuildScript(
    filename: Config.Path,
-    options: Options | null,


seems to have been a bug, it was never passed null 🤷‍♂

…pshots * upstream/master: (225 commits) docs: add CLA link to contributing docs (jestjs#9789) chore: roll new version of docs v25.3.0 chore: update changelog for release chore(jest-types): correct type testRegex for ProjectConfig (jestjs#9780) feat(circus): enable writing async test event handlers (jestjs#9397) feat: enable all babel syntax plugins (jestjs#9774) chore: add helper for getting Jest's config in e2e tests (jestjs#9770) feat: pass ESM options to transformers (jestjs#9597) chore: replace `any`s with `unknown`s (jestjs#9626) feat: pass ESM options to Babel (jestjs#9766) chore(website): add copy button the code blocks (jestjs#9750) chore: bump istanbul-reports for new uncovered lines design (jestjs#9758) chore: correct CHANGELOG.md (jestjs#9763) chore(jest-types): expose type `CacheKeyOptions` for `getCacheK… (jestjs#9762) docs: Fix simple typo, seperated -> separated (jestjs#9760) v25.2.7 chore: update changelog for release fix: drop getters and setters when diffing objects for error (jestjs#9757) chore(jest-types): correct return type of shouldRunTestSuite fo… (jestjs#9753) ...

github-actions · 2021-05-11T09:07:08Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

SimenB added the ES Modules label Feb 19, 2020

SimenB requested review from jeysal and thymikee February 19, 2020 11:56

facebook-github-bot added the cla signed label Feb 19, 2020

SimenB commented Feb 19, 2020

View reviewed changes

Comment thread packages/jest-runtime/tsconfig.json

SimenB commented Feb 19, 2020

View reviewed changes

thymikee reviewed Feb 19, 2020

View reviewed changes

Comment thread packages/babel-jest/src/__tests__/index.ts Outdated

thymikee approved these changes Feb 19, 2020

View reviewed changes

SimenB force-pushed the pass-esm-options-to-transformers branch from 5f6eac4 to a7fac13 Compare February 20, 2020 15:19

SimenB mentioned this pull request Apr 4, 2020

Implement async code transformations #9504

Closed

SimenB force-pushed the pass-esm-options-to-transformers branch from a7fac13 to 6aa31e9 Compare April 4, 2020 14:11

SimenB mentioned this pull request Apr 4, 2020

feat: pass ESM options to Babel #9766

Merged

SimenB force-pushed the pass-esm-options-to-transformers branch from 6aa31e9 to 17285a9 Compare April 5, 2020 09:06

SimenB commented Apr 5, 2020

View reviewed changes

SimenB force-pushed the pass-esm-options-to-transformers branch from 17285a9 to 75fd400 Compare April 5, 2020 09:35

feat: pass ESM options to transformers

2f163d9

SimenB force-pushed the pass-esm-options-to-transformers branch from 75fd400 to 2f163d9 Compare April 5, 2020 09:43

SimenB merged commit edf8c0a into jestjs:master Apr 5, 2020

SimenB deleted the pass-esm-options-to-transformers branch April 5, 2020 10:15

ahnpnl mentioned this pull request Apr 10, 2020

RFC: Leverage --incremental kulshekhar/ts-jest#1310

Open

This was referenced May 1, 2020

[Snyk] Upgrade jest from 25.2.7 to 25.3.0 mkai/express-absolute-url#10

Merged

[Snyk] Upgrade: jest, jest-cli lwojcik/sc2pte-panel-frontend#123

Closed

github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021

Uh oh!

Conversation

SimenB commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

codecov-io commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

SimenB Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

SimenB Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

thymikee Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

SimenB Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thymikee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thymikee Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

SimenB commented Apr 5, 2020

Uh oh!

SimenB Apr 5, 2020

Choose a reason for hiding this comment

Uh oh!

SimenB Apr 5, 2020

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SimenB commented Feb 19, 2020 •

edited

Loading

codecov-io commented Feb 19, 2020 •

edited

Loading