Skip to content

docs: Clarify scope of jest.setTimeout#9676

Merged
SimenB merged 1 commit intojestjs:masterfrom
raphinesse:patch-1
Mar 25, 2020
Merged

docs: Clarify scope of jest.setTimeout#9676
SimenB merged 1 commit intojestjs:masterfrom
raphinesse:patch-1

Conversation

@raphinesse
Copy link
Copy Markdown
Contributor

Summary

It was not clear to me what scope the effect of calling jest.setTimeout(timeout) would have, i.e. whether the default timeout would change only for the test file or describe block where the call originated or for all tests executed after the call.

Test plan

The behavior that I describe here was reverse-engineered by experiment, since I could not immediately find the implementation of it. So it would be great to have my findings confirmed by someone who understands the implementation.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @raphinesse!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 682e310 into jestjs:master Mar 25, 2020
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants