Fixes #15267 - Introduce module for MinimumDataRateHandler.#15268
Merged
sbordet merged 2 commits intoJun 10, 2026
Merged
Conversation
* Improved EventsHandler by changing `onResponseWriteComplete()` to take also the `last` and the content `ByteBuffer` as parameters. This allows a more precise accounting for written bytes. * Updated `StatisticsHandler` to account for written bytes only if they are successfully written. * Deprecated `HttpConfiguration.minRequestDataRate` and `HttpConfiguration.minResponseDataRate`. Only the former was still used, and only in Servlet code, but the mechanism should be replaced by `MinimumDataRateHandler`. * Remove dead code in eeN's `HttpOutput` that was referring to `HttpConfiguration.minResponseDataRate` without actually enforcing the rate. * Introduced `min-data-rate.mod`. * Moved `MinimumDataRateHandler` to upper level, and added more tests. * Updated documentation. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
rickardoberg
previously approved these changes
Jun 10, 2026
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
Jun 10, 2026
sbordet
deleted the
fix/jetty-12.1.x/15267-module-for-min-data-rate-handler
branch
|
Hi @sbordet, this PR was merged without any labels. Please add at least one label (e.g., Bug, Enhancement, Documentation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onResponseWriteComplete()to take also thelastand the contentByteBufferas parameters. This allows a more precise accounting for written bytes.StatisticsHandlerto account for written bytes only if they are successfully written.HttpConfiguration.minRequestDataRateandHttpConfiguration.minResponseDataRate. Only the former was still used, and only in Servlet code, but the mechanism should be replaced byMinimumDataRateHandler.HttpOutputthat was referring toHttpConfiguration.minResponseDataRatewithout actually enforcing the rate.min-data-rate.mod.MinimumDataRateHandlerto upper level, and added more tests.