Issue #5320 - using jetty-websocket-httpclient.xml within webapp#5374
Merged
lachlan-roberts merged 13 commits intojetty-9.4.xfrom Nov 2, 2020
Merged
Issue #5320 - using jetty-websocket-httpclient.xml within webapp#5374lachlan-roberts merged 13 commits intojetty-9.4.xfrom
lachlan-roberts merged 13 commits intojetty-9.4.xfrom
Conversation
…t in webapp Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…cess. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Oct 6, 2020
lachlan-roberts
requested review from
gregw and
sbordet
and removed request for
gregw
sbordet
requested changes
Oct 12, 2020
Member
Author
|
@sbordet you asked me to add the case where we provide the websocket client classes in Don't you use some shaded jars in cometd to get around this problem? |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…20-WebSocketHttpClient
…client.xml Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…20-WebSocketHttpClient Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…20-WebSocketHttpClient
sbordet
requested changes
Nov 2, 2020
| @@ -42,10 +37,8 @@ | |||
|
|
|||
| public class WebSocketExtensionFactory extends ExtensionFactory implements LifeCycle, Dumpable | |||
Contributor
There was a problem hiding this comment.
This class extends a deprecated class -- should this class be deprecated as well?
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5320
Run the
jetty-websocket-httpclient.xmlwith server class access ifWebAppClassLoaderis available.