-
Notifications
You must be signed in to change notification settings - Fork 29
http. RoundTripper is not re-used #10
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
For the bitbucketserver and github vcsclient(s) the http.RoundTripper is not re-used, but created for each new request if client.vcsInfo.Token is provided.
This can cause an issue because connections acquire file descriptors and won't be released immediately after http.Client garbage collection, please see https://golang.org/src/net/http/transport.go#L68
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working