Skip to content

Consolidate sign-in to dedicated page#13

Merged
jhash merged 1 commit intomainfrom
sign-in
Jul 25, 2025
Merged

Consolidate sign-in to dedicated page#13
jhash merged 1 commit intomainfrom
sign-in

Conversation

@jhash
Copy link
Copy Markdown
Owner

@jhash jhash commented Jul 25, 2025

Summary

  • Created a new sign-in page at /sign_in with centered layout and both OAuth providers
  • Replaced the dual sign-in buttons in navbar with a single "Sign in" link
  • Ensured sidebar shows for all logged-in users with conditional super admin links

Test plan

  • Sign-in page displays correctly with centered layout
  • Both Google and GitHub OAuth buttons work
  • Navbar shows single "Sign in" link for non-authenticated users
  • Sidebar displays for all logged-in users
  • Admin menu items only show for superadmins
  • All tests pass
  • Rubocop passes with no offenses

🤖 Generated with Claude Code

- Create new sign-in page at /sign_in with centered layout
- Replace dual sign-in buttons in navbar with single "Sign in" link
- Add sessions#new action to handle sign-in page
- Fix test fixtures for users and identities
- Install ActionText dependencies (required by tests)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@jhash jhash marked this pull request as ready for review July 25, 2025 23:18
@jhash jhash merged commit fdb9232 into main Jul 25, 2025
4 checks passed
jhash added a commit that referenced this pull request Jul 26, 2025
- Create new sign-in page at /sign_in with centered layout
- Replace dual sign-in buttons in navbar with single "Sign in" link
- Add sessions#new action to handle sign-in page
- Fix test fixtures for users and identities
- Install ActionText dependencies (required by tests)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant