Skip to content

Update to tidyverse 4.4#5

Merged
cansavvy merged 14 commits intomainfrom
cansavvy/bump-rocker
Mar 25, 2025
Merged

Update to tidyverse 4.4#5
cansavvy merged 14 commits intomainfrom
cansavvy/bump-rocker

Conversation

@cansavvy
Copy link
Copy Markdown
Contributor

Summary

Earlier rocker versions have problems with Mac silicon: rocker-org/rocker-versioned2#144

They have this fix in the more recent versions.

We encounter that this hasn't been updated when @obigriffith reviewed fhdsl/Containers_for_Scientists#17

So bumping here

@cansavvy
Copy link
Copy Markdown
Contributor Author

successfully built and pushed to dockerhub

Comment thread docker/Dockerfile Outdated

RUN pip3 install \
"pyrefinebio"
"pyrate-limiter==2.7.0" \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version listed in pyrefinebio

Suggested change
"pyrate-limiter==2.7.0" \
"pyrate-limiter==2.10.0" \

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately didn't fix the problem. Tried rebuilding.

Copy link
Copy Markdown
Contributor Author

@cansavvy cansavvy Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in the docker image pip show pyrate_limiter shows

Name: pyrate-limiter
Version: 2.10.0
Summary: Python Rate-Limiter using Leaky-Bucket Algorithm
Home-page: https://github.com/vutran1710/PyrateLimiter
Author: vutr
Author-email: me@vutr.io
License: MIT
Location: /usr/local/lib/python3.12/dist-packages
Requires: 
Required-by: 

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at the one being pulled by your tests, jhudsl/reproducible-r:latest, it still has the newer version:

❯ docker run jhudsl/reproducible-r:latest pip show pyrate_limiter
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Name: pyrate-limiter
Version: 3.0.0
Summary: Python Rate-Limiter using Leaky-Bucket Algorithm
Home-page: https://github.com/vutran1710/PyrateLimiter
Author: vutr
Author-email: me@vutr.io
License: MIT
Location: /usr/local/lib/python3.12/dist-packages
Requires:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally, I can use the following two commands and get a successful run:

❯ docker build -f docker/Dockerfile . -t jhudsl/reproducible-r:test --platform linux/amd64
❯ docker run \
  --mount type=bind,target=/home/rstudio,source=$PWD \
  jhudsl/reproducible-r:test \
  bash run_analysis.sh

Copy link
Copy Markdown
Contributor Author

@cansavvy cansavvy Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Such a stupid reason. I've been using the wrong docker image name. It's jhudsl/reproducible-r NOT jhudsl/reproducible-r-example. 😅

Thanks for the help @jashapiro

@cansavvy
Copy link
Copy Markdown
Contributor Author

Docker issue is just a secret related problem so not related to this PR.

@cansavvy cansavvy merged commit 114a861 into main Mar 25, 2025
1 of 2 checks passed
@cansavvy cansavvy deleted the cansavvy/bump-rocker branch March 25, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants