Guest hostname handling improvements (with override)#48
Guest hostname handling improvements (with override)#48jingkaihe merged 10 commits intojingkaihe:mainfrom
Conversation
Set hostname before user-space via kernel arg and write to /etc/hostname for wider compatibility. Allow override via VMConfig or MATCHLOCK_HOSTNAME.
|
Thanks for contiributing. Can we do |
|
Makes sense, removed Good idea re: For |
|
I'd prefer avoiding dependencies and just write lines into the Typically OCI images do not have /etc/hosts as they are typically mounted, therefore I believe it is fairly safe to override it manually. |
|
Fair enough, if we're not adding a dependency I'll just roll it into this PR shortly. |
67e4034 to
e40a837
Compare
|
Done! |
|
I'll add support for adding the file from scratch as well on images that do not have /etc/hosts at all (eg. ubuntu:latest) |
…iguration Signed-off-by: Jingkai He <jingkai@hey.com>
e40a837 to
8fff2d7
Compare
|
Done! |
8fff2d7 to
f3c6428
Compare
Signed-off-by: Jingkai He <jingkai@hey.com>
…me feature Signed-off-by: Jingkai He <jingkai@hey.com>
This PR improves guest hostname handling by:
MATCHLOCK_HOSTNAMEWithout override:
With override: