fix(host-detection): prefer user-defined NEXTAUTH_URL over automatic "forwardedHost" in Vercel environment#1
Merged
Conversation
…"forwardedHost" in Vercel environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR affects behavior that can only be observed in Vercel deployments.
The commit reverts behavior introduced by nextauthjs#3649, where the user-defined environment variable
NEXTAUTH_URLis ignored in favor of the value ofx-forwarded-host.☕️ Reasoning
If a user deliberately sets a
NEXTAUTH_URLenvironment variable, it means they wanted Vercel to use this as the canonical URL. next-auth should consider this deliberately defined value first and then fallback to automatic behavior otherwise. The current behavior, which is to usex-forwarded-hostwhen available and fallback to user-definedNEXTAUTH_URL(on top of being surprising and not consistent with the documentation) breaks in multiple situations, including our current staging environment:redirect_urito staging.example.com.redirect_uri=<preview_url>which is practically guaranteed to not be whitelisted by your provider (since you can't know the auto-generated preview URL ahead of time).🧢 Checklist
Documentationconsistent with existing