Porting initial HDRadio support to 1.3-devel.#376
Open
luarvique wants to merge 3 commits intojketterl:developfrom
Open
Porting initial HDRadio support to 1.3-devel.#376luarvique wants to merge 3 commits intojketterl:developfrom
luarvique wants to merge 3 commits intojketterl:developfrom
Conversation
jketterl
reviewed
Mar 17, 2024
| FM broadcasts. Nrsc5 is not yet available as a package and thus you will have | ||
| to compile it from source. | ||
| """ | ||
| return self.command_is_runnable("nrsc5 -v") |
Owner
There was a problem hiding this comment.
Given that the code only depends on the library (not the actual executable), I think that it would be a good idea to change this to test for the library as well. Not sure if it will bring a big advantage, but this would allow the library to come as a separate package, reducing the dependencies when possible.
Author
There was a problem hiding this comment.
Yeah, that should not be a problem. The original integration did use the executable, hence the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the port of the initial HDRadio support from OWRX+ into OWRX 1.3-develop. Not guaranteed to work. Obviously requires NRSC5 software.