Local extras should override extras given in init#16
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 96.81% 96.83% +0.01%
==========================================
Files 3 3
Lines 220 221 +1
==========================================
+ Hits 213 214 +1
Misses 7 7
Continue to review full report at Codecov.
|
Signed-off-by: Cyril Martin <c.martin@criteo.com>
Owner
|
Indeed, the |
Owner
|
Fixed in release v1.1.2 |
vphpersson
pushed a commit
to vphpersson/rfc5424-logging-handler
that referenced
this pull request
Mar 23, 2026
Local extras should override extras given in init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to commit dcd32d1.
When an extra is given twice: in init and in a local call to logger, I think the local value should override the first one. My opinion.
Note: I really dislike my loop too :-). So you can discard my PR if you find a more elegant way to implement this override.
Signed-off-by: Cyril Martin c.martin@criteo.com