Mount zip file doesn't work since version 0.83.23 ?

[aetchris]

Describe the bug

Programs mounted in zip files don't launch since after version 0.83.23.

Steps to reproduce the behaviour

Mount a zip file as drive c
Try to launch program
Dosbox-x hangs and program doesn't launch

Expected behavior

In version 0.83.23, the program launches.
After this version, dosbox-x seems to hang up with a black screen

What operating system(s) this bug have occurred on?

Windows 10

What version(s) of DOSBox-X have this bug?

Since 0.83.24

Used configuration

mount C "pathtozipfile\file.zip:\"
C:
cd\
program.exe

Output log

Many "ERROR CPU:Illegal Unhandled Interrupt Called 6" in output

373108514 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373108611 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373108708 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373108805 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373108902 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373108999 ERROR CPU:Illegal Unhandled Interrupt Called 6
 373109096 ERROR CPU:Illegal Unhandled Interrupt Called 6

Additional information

No response

Have you checked that no similar bug report(s) exist?

• I have searched and didn't find any similar bug report.

Code of Conduct & Contributing Guidelines

• I agree to follow the code of conduct and the contributing guidelines.

[grapeli]

I confirm does not work from the moment of introducing these changes #3347.

[aetchris]

The issue seems to be resolved in version 0.84.1. Thanks a lot!

[grapeli]

I have not noticed any improvement. It still does not work.

keen6.zip
bomber.7z.txt

dosbox-x -c "mount c ./bomber.7z" -c "c:" -c "cd 3dbomber" -c bomb
dosbox-x -c "mount c ./keen6.zip" -c "c:" -c keen6

After undoing these unfortunate code changes #3347, it works.

[aetchris]

Well, that's strange... The issue seems to persist on some programs, and not others... For example, "Elite" in a zip file works, whereas "Elite plus" in a zip file doesn't.

[NebularNerd]

I have the same issue with an old Dynamix title 'Stellar 7' happy to supply zip if needed.

[grapeli]

I am surprised by the long lack of response to reporting this bug from developers.

For those who need this functionality and are able to compile on their own, I suggest undoing these unfortunate changes to the code.
revert-3347-fix-mount-zip.patch.txt

[tbr]

Hi, I'd also like to confirm that this problem persists. An example to trigger this bug is to use (in DosBox-X) "edit somefile.txt" where "somefile.txt" is a file inside a mounted zip file as drive (with an overlay mount on top of it). DosBox-X will hang while spawning the interrupt 6 error on console as described in this issue.

Moreover, I was reviewing merge #3347 and I believe that there is also a mistake made (but I might be wrong): on dos.cpp:line1895 there is now a call to MEM_BlockRead which seems wrong (I think it should be MEM_BlockWrite) as it is the code for 0x3f (File Read) which reads from file (writing) into a memory block.

[NebularNerd]

Looking forward to seeing this fixed, I'm trying to compile the code with @grapeli patch but it's been a while since I did some basic compiling and things are much more complicated now.

The .zip thing has been one of the great things added to DosBox, the ability to enjoy a program or game freely without harm to the original install is ideal for both preserving and running multiple copies of a base install (Say Win 3.1) but with different driver/software combinations as required, any issues occur you can simply delete the overlay directory for that run and start again. With modern systems the speed difference is barely appreciable.

[NebularNerd]

Just seen this was merged last night and tested with build dosbox-x-vsbuild-win64-20220901051309, My copy of Stellar 7 now plays from inside a regular .zip and my stupidly high compressed .7z without issue.

Big thumbs up to @tbr for the fix. 👍😁

[tbr]

While this is now fixed, I'm seeing still some issues when combining ZIP/7Z drive mounts with an overlay folder (for writing changes, like save games). So, more debugging is probably advised.

[NebularNerd]

While this is now fixed, I'm seeing still some issues when combining ZIP/7Z drive mounts with an overlay folder (for writing changes, like save games). So, more debugging is probably advised.

I played tested a few games yesterday all using an overlay and had no issues personally. If I come across one I'll update this reply. I'm sure there will be a couple of games in my collection that access drives in a weird and wonderful manner.