Fix duplicate test names preventing test runs.#134
Merged
jordaneremieff merged 2 commits intoKludex:mainfrom Aug 9, 2020
Merged
Fix duplicate test names preventing test runs.#134jordaneremieff merged 2 commits intoKludex:mainfrom
jordaneremieff merged 2 commits intoKludex:mainfrom
Conversation
|
Nice find! |
Collaborator
|
Good catch, thank you! |
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Mar 27, 2021
* Fix duplicate test_http_request preventing test runs. * Remove duplicate http response headers test.
four43
pushed a commit
to four43/mangum
that referenced
this pull request
Aug 20, 2021
* Fix duplicate test_http_request preventing test runs. * Remove duplicate http response headers test.
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* Fix duplicate test_http_request preventing test runs. * Remove duplicate http response headers test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, this project is super cool! ❤️
While I was looking through the code, I noticed that there was a re-declaration of a test (
test_http_requestwas declared twice intest_http.py[1 2]) which was preventing one of the tests from running.This PR renames the duplicate test and fixes the resulting test failure that was exposed!
Also, I noticed the
test_http_response_headerstest appears to be duplicated so I removed the duplicate.