Fix ALB multi value headers#189
Merged
jordaneremieff merged 4 commits intoKludex:mainfrom Jun 5, 2021
Merged
Conversation
jordaneremieff
requested changes
May 23, 2021
Collaborator
|
@jurasofish thanks! The ALB support in Mangum is still fairly new territory and not something I'm particularly across, so I appreciate the investigation/fixing up the test coverage. I've opened a review with some questions. Mainly I'm trying to understand the differences between the initial implementation, the refactored version, and the new changes in your PR. |
…t[bytes]]` up to where the headers are initially transformed
jordaneremieff
requested changes
May 28, 2021
jordaneremieff
approved these changes
Jun 5, 2021
Collaborator
|
Thanks! |
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* copy with some slight changes from Kludex#179 * move headers conversion from `List[Tuple[bytes, bytes]]` to `List[List[bytes]]` up to where the headers are initially transformed * no longer assert that first case mutated string is lowercase * only pull headers from one of `multiValueHeaders` and `headers`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken multi value headers for ALB, as described in #187.
This is largely a copy past of #179 just with some small changes.
Sorry the changes to testing are so substantial, just had to add a lot of logic to handle with/without multi value headers.
Closes #187
Closes #179
I spoke to AWS support about the case mutations.
They wouldn't guarantee it as a supported way of using ALB, but they didn't say it wasn't supported either....
They guy just spun up an ALB and confirmed empirically that it worked, which we already knew.
Whatever, it didn't hurt to ask