This repository was archived by the owner on Aug 12, 2023. It is now read-only.
feat(builtins): add gotests support in code actions#1362
Open
joshrwolf wants to merge 2 commits intojose-elias-alvarez:mainfrom
Open
feat(builtins): add gotests support in code actions#1362joshrwolf wants to merge 2 commits intojose-elias-alvarez:mainfrom
joshrwolf wants to merge 2 commits intojose-elias-alvarez:mainfrom
Conversation
joshrwolf
force-pushed
the
gotests-code-action
branch
from
bca4544 to
08c1425
Compare
Owner
|
This looks good, thanks! Can you go ahead and remove the extra print statements and also let me know how I can test this in case I have to investigate issues in the future? |
Author
|
thanks for the 👀! is there a designated place in the codebase for leaving testing information (like the |
Owner
|
Just in this PR is fine - I found the approach in #1339 helpful to review the PR and then to test an additional change. |
Contributor
|
Can we get it merged, please? Also docs are needed to be updated, need fixing treesitter deprecations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
gotestsas a builtin code action with 2 operating modes:package_clause)identifier)This PR is heavily influenced by the awesome work in #1339.