Allow arguments passed to sort()

[joshwlivingston]

._discrete_choice_inputs() should allow arguments passed to sort()

Existing:

if (!isTRUE(choices_asis)) {
  x <- sort(unique(x))
}

Possible implementation:

if (!isTRUE(choices_asis)) {
  args_sort <- args[names(args) %in% formalArgs(sort)]
  x <- do.call(sort, list(x = unique(x), args_sort))
}

[joshwlivingston]

Few things:

• base::sort() is a generic, so formalArgs() is not going to work as intended here
• decreasing is an argument of sort()
  • So, decreasing is expected, with ... passed to ... in base::sort()
    • Q: what happens when an argument in ... is passed to method on sort that does not contain that argument ?

[joshwlivingston]

Q: what happens when an argument in ... is passed to method on sort that does not contain that argument ?

Addressed in ._eval_generic() (merged in #50):

if (identical(method_x, sort.default) && !is.object(x)) {
		# sort.default(), when is.object(x) is FALSE, calls `sort.int()`, using
		# `...` to pass arguments through. `sort.int()`, however, does not accept
		# `...` as an argument.
		#
		# So, when shinyfilters attempts to pass `...` to `sort.int()`, we get an
		# invalid argument error (inputId, label, etc).
		#
		# The result is the need to be explicit about arguments passed to
		# `sort.default()`.
		#
		# Here, we take the union of the arguments for `sort.default()` and
		# `sort.int()`, excluding `...`.
		args_method_all <- setdiff(
			union(args_method_all, formalArgs(sort.int)),
			"..."
		)
	}