Migrate Scale.spec.replicas to declarative#141
Merged
thockin merged 7 commits intovalidation-genfrom Apr 14, 2025
Merged
Conversation
jpbetz
force-pushed
the
subresources-enable-replicas
branch
4 times, most recently
from
0c84b68 to
866e377
Compare
jpbetz
changed the title
jpbetz
commented
Mar 20, 2025
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
yongruilin
reviewed
Mar 25, 2025
yongruilin
force-pushed
the
validation-gen
branch
3 times, most recently
from
cdbf203 to
d78db0f
Compare
jpbetz
force-pushed
the
subresources-enable-replicas
branch
from
866e377 to
21f21b6
Compare
Owner
Author
|
Thanks @yongruilin feedback applied. |
thockin
reviewed
Mar 28, 2025
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
jpbetz
force-pushed
the
subresources-enable-replicas
branch
2 times, most recently
from
05110ba to
84f5165
Compare
Owner
Author
|
@thockin All feedback applied |
jpbetz
force-pushed
the
subresources-enable-replicas
branch
3 times, most recently
from
ce2a7b2 to
230d392
Compare
thockin
reviewed
Apr 14, 2025
Collaborator
thockin
left a comment
thockin
left a comment
There was a problem hiding this comment.
I only see the new request.Subresources[] field in tests -- am I missing it, or it's just not used for real yet?
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/registry/core/replicationcontroller/storage/scale_declarative_validation_test.go
Outdated
Show resolved
Hide resolved
This adds declarative validation for all all versioned types of Scale since our testing uses apitesting.VerifyVersionedValidationEquivalence, will fail if we don't convert them all at the same time.
This applies to all group version kinds of Scale. Validation-gen must be enabled for all at the same time since our testing checks that cross-GV declarative validation to matches.
…pec.replicas validation. This does not change the resulting errors but it makes declarative validation testing easier.
jpbetz
force-pushed
the
subresources-enable-replicas
branch
from
230d392 to
9e7e3e4
Compare
Owner
Author
It might be quite some time before we actually use |
Owner
Author
|
Thanks @thockin. Feedback applied |
Owner
Author
It's not used for real yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #140
This sets up the wiring for replicationcontroller/scale and provides and example of how to do it in general.
Note that this does not re-evaluate the pre-existing decision that scale subresource be double validated-- once against scale subresource validation and then again against containing resource validation.
Testing in the storage package is not ideal. Suggestion welcome.